Add logic for table format-version updates#55
Merged
Fokko merged 3 commits intoapache:mainfrom Oct 10, 2023
Merged
Conversation
Add a few more tests
rdblue
approved these changes
Oct 9, 2023
Contributor
|
Looks good to me. I personally like using more descriptive verbs, like "upgrade" instead of "set" since this only allows upgrading the version, but I don't think it's a blocker (especially since the method was already there). |
Contributor
Author
|
@rdblue I agree with you there. I think we can still update the method name since it was just raising an exception. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a few more tests