Add flake8-pie to ruff

pyiceberg/io/pyarrow.py

@@ -1502,7 +1502,7 @@ def fill_parquet_file_metadata(
 
         invalidate_col: Set[int] = set()
 
-        for pos in range(0, parquet_metadata.num_columns):
+        for pos in range(parquet_metadata.num_columns):
             column = row_group.column(pos)
             field_id = parquet_column_mapping[column.path_in_schema]
 

pyproject.toml

@@ -298,6 +298,7 @@ select = [
     "W", # pycodestyle
     "F", # Pyflakes
     "B", # flake8-bugbear
+    "PIE", # flake8-pie
     "C4", # flake8-comprehensions
     "I", # isort
     "UP", # pyupgrade

tests/test_integration.py

@@ -116,7 +116,7 @@ def test_table_properties(table: Table) -> None:
     with table.transaction() as transaction:
         transaction.set_properties(abc="🤪")
 
-    assert table.properties == dict(**{"abc": "🤪"}, **DEFAULT_PROPERTIES)
+    assert table.properties == dict(abc="🤪", **DEFAULT_PROPERTIES)
 
     with table.transaction() as transaction:
         transaction.remove_properties("abc")
@@ -125,7 +125,7 @@ def test_table_properties(table: Table) -> None:
 
     table = table.transaction().set_properties(abc="def").commit_transaction()
 
-    assert table.properties == dict(**{"abc": "def"}, **DEFAULT_PROPERTIES)
+    assert table.properties == dict(abc="def", **DEFAULT_PROPERTIES)
 
     table = table.transaction().remove_properties("abc").commit_transaction()
 
@@ -224,13 +224,7 @@ def test_ray_all_types(table_test_all_types: Table) -> None:
 
 @pytest.mark.integration
 def test_pyarrow_to_iceberg_all_types(table_test_all_types: Table) -> None:
-    fs = S3FileSystem(
-        **{
-            "endpoint_override": "http://localhost:9000",
-            "access_key": "admin",
-            "secret_key": "password",
-        }
-    )
+    fs = S3FileSystem(endpoint_override="http://localhost:9000", access_key="admin", secret_key="password")
     data_file_paths = [task.file.file_path for task in table_test_all_types.scan().plan_files()]
     for data_file_path in data_file_paths:
         uri = urlparse(data_file_path)

tests/test_types.py

@@ -496,7 +496,7 @@ def test_repr_nestedfield() -> None:
 def test_nestedfield_by_alias() -> None:
     # We should be able to initialize a NestedField by alias
     expected = NestedField(1, "required_field", StringType(), True, "this is a doc")
-    actual = NestedField(**{"id": 1, "name": "required_field", "type": "string", "required": True, "doc": "this is a doc"})  # type: ignore
+    actual = NestedField(id=1, name="required_field", type="string", required=True, doc="this is a doc")
     assert expected == actual