feat: Add conversion from FileMetaData to ParquetMetadata#1074
Merged
liurenjie1024 merged 5 commits intoapache:mainfrom Mar 14, 2025
Merged
feat: Add conversion from FileMetaData to ParquetMetadata#1074liurenjie1024 merged 5 commits intoapache:mainfrom
FileMetaData to ParquetMetadata#1074liurenjie1024 merged 5 commits intoapache:mainfrom
Conversation
3 tasks
liurenjie1024
previously approved these changes
Mar 13, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @jonathanc-n , LGTM! Just a minor concern about thrift depdenency, let's wait for @Xuanwo to take a look.
Xuanwo
reviewed
Mar 13, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Most changes looks good to me. It's better if we can remove some unwarp().
Contributor
Author
|
@Xuanwo @liurenjie1024 Should be fine now. Thanks for the review! |
liurenjie1024
approved these changes
Mar 14, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
LGTM, thanks @jonathanc-n !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Add conversion from filemetadat to parquet metadata using thrift
decode_metadataAre these changes tested?