ci: only use -Z direct-minimal-versions for MSRV check
#1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
changed the title
-Z minimal-versions for MSRV check
kevinjqliu
force-pushed
the
kevinjqliu/remove-msrv-minimal-versions
branch
from
06dc77a to
32167f0
Compare
Contributor
|
I'm +1 with this change, and I think only |
kevinjqliu
force-pushed
the
kevinjqliu/remove-msrv-minimal-versions
branch
from
32167f0 to
3ba8ed5
Compare
kevinjqliu
changed the title
-Z minimal-versions for MSRV check-Z direct-minimal-versions for MSRV check
Contributor
Author
|
I found some context on using |
Contributor
|
I'm by no means an expert on the subject, but I don't see many project havingt his check. I would be in favor of dropping |
xxchan
reviewed
Sep 8, 2025
Member
xxchan
left a comment
xxchan
left a comment
There was a problem hiding this comment.
I agree direct-minimal-versions seem to be the more wanted semantics, but I remember I met some problems making it work (do not remember the exact problem), thus adding minimal-versions also.
Member
|
Oh, IIRC, it's because some transitive dependency uses higher MSRV, so |
xxchan
approved these changes
Sep 8, 2025
Fokko
approved these changes
Sep 8, 2025
Contributor
Author
|
thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Context: #1195 (comment)
the docs mentions that the feature is not recommended anymore
I've ran an issue with this flag when upgrading datafusion from 47 -> 48. -Z minimal-versions will pull in very old versions of transitive dependencies
Are these changes tested?