Closed
Conversation
dentiny
force-pushed
the
hjiang/upgrade-arrow-parquet
branch
2 times, most recently
from
d13b1ff to
dc4cf9b
Compare
dentiny
commented
Oct 15, 2025
| .with_column_indexes(self.preload_column_index) | ||
| .with_page_indexes(self.preload_page_index) | ||
| .with_offset_indexes(self.preload_offset_index); | ||
| .with_column_index_policy(if self.preload_column_index { |
Contributor
Author
There was a problem hiding this comment.
Old API already deprecated
dentiny
commented
Oct 15, 2025
| datafusion = "48.0.1" | ||
| datafusion-cli = "48.0.1" | ||
| datafusion-sqllogictest = "48.0.1" | ||
| datafusion = "50.0" |
Contributor
Author
There was a problem hiding this comment.
datafusion v50 already updates to the latest arrow and parquet
Contributor
Contributor
Author
Collaborator
|
Can we go straight to 50.2? It should not have API breakages. I just did this for Comet and it was painless, though Comet does not use the DataFusion front-end. apache/datafusion-comet#2575 |
Contributor
Author
Thanks for the info, will check after df upgrade |
Member
|
block has been removed, sorry for the wait. |
Contributor
Author
|
I think @mbutrovich did a better job on PR #1830 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR upgrades parquet and arrow to the v56.0, which is compatible with delta-rs
https://github.com/delta-io/delta-rs/blob/d950bf2193229be1fbd5e069b9f8ce68ddef6a13/Cargo.toml#L37-L49
Are these changes tested?
This PR should be a no-op change, existing tests should be enough.