General support for metadata columns + implementation for _pos#1791
General support for metadata columns + implementation for _pos#1791vustef wants to merge 8 commits intoapache:mainfrom
_pos#1791Conversation
Update from upstream
…lds at arrow-rs 57.0
| /// | ||
| /// Metadata columns are virtual columns that provide metadata about the rows, | ||
| /// such as file paths or row positions. These come from https://iceberg.apache.org/spec/#identifier-field-ids | ||
| pub fn with_metadata_columns(mut self, metadata_columns: Vec<String>) -> Self { |
There was a problem hiding this comment.
Need some validation here, for allowed column names. Or type safety, to pick columns from enum (possibly preventing duplication?)
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Similar comments here: #1824 (review)
|
Blueprint of how we're thinking about this: RelationalAI#14 |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
3 participants
Which issue does this PR close?
#1765
What changes are included in this PR?
Are these changes tested?