-
Notifications
You must be signed in to change notification settings - Fork 395
feat(datafusion): Support CREATE TABLE for DataFusion
#1972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
liurenjie1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CTTY for this pr, I think we also should create a tracking issue for create external table?
Yes, I think we currently have My current thought: we will need to introduce some new catalog props and pass them to I haven't thought quite thoroughly yet, and will create a tracking issue later, we can move the discussion there |
|
Created an issue to track create external table: #2021 |
liurenjie1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CTTY for this fix!
Which issue does this PR close?
What changes are included in this PR?
register_tableinIcebergSchemaProvidercreate_table.sltNote: This does NOT cover the syntax
CREATE TABLE ... AS VALUESAre these changes tested?
Yes