Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/iceberg/src/arrow/delete_file_loader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ use std::sync::Arc;
use futures::{StreamExt, TryStreamExt};

use crate::arrow::ArrowReader;
use crate::arrow::reader::ParquetMetadataCache;
use crate::arrow::record_batch_transformer::RecordBatchTransformerBuilder;
use crate::io::FileIO;
use crate::scan::{ArrowRecordBatchStream, FileScanTaskDeleteFile};
Expand All @@ -43,12 +44,16 @@ pub trait DeleteFileLoader {
#[derive(Clone, Debug)]
pub(crate) struct BasicDeleteFileLoader {
file_io: FileIO,
metadata_cache: ParquetMetadataCache,
}

#[allow(unused_variables)]
impl BasicDeleteFileLoader {
pub fn new(file_io: FileIO) -> Self {
BasicDeleteFileLoader { file_io }
BasicDeleteFileLoader {
file_io,
metadata_cache: ParquetMetadataCache::default(),
}
}
/// Loads a RecordBatchStream for a given datafile.
pub(crate) async fn parquet_to_batch_stream(
Expand All @@ -64,6 +69,7 @@ impl BasicDeleteFileLoader {
self.file_io.clone(),
false,
None,
&self.metadata_cache,
)
.await?
.build()?
Expand Down
7 changes: 4 additions & 3 deletions crates/iceberg/src/arrow/delete_filter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,10 @@ impl DeleteFilter {

// Mark as loading to prevent duplicate work
let notifier = Arc::new(Notify::new());
state
.equality_deletes
.insert(file_path.to_string(), EqDelState::Loading(notifier.clone()));
state.equality_deletes.insert(
file_path.to_string(),
EqDelState::Loading(Arc::clone(&notifier)),
);

Some(notifier)
}
Expand Down
Loading
Loading