Make convert_filters_to_predicate public#2118
Merged
blackmwk merged 1 commit intoapache:mainfrom Mar 30, 2026
Merged
Conversation
Contributor
Author
|
We have implemented a custom |
LLDay
force-pushed
the
feat/public-method
branch
2 times, most recently
from
04fa04d to
3e1f59c
Compare
LLDay
force-pushed
the
feat/public-method
branch
from
3e1f59c to
e229b7a
Compare
Contributor
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
LLDay
force-pushed
the
feat/public-method
branch
from
e229b7a to
eba5ffb
Compare
Contributor
Author
|
@blackmwk, could you please review this small PR? |
blackmwk
approved these changes
Mar 30, 2026
toutane
pushed a commit
to DataDog/iceberg-rust
that referenced
this pull request
Apr 30, 2026
## What changes are included in this PR? - Make `convert_filters_to_predicate` public in the DataFusion integration to allow external usage of the filter conversion logic. ## Are these changes tested? - This is a visibility change (`pub use`) and does not introduce new logic. Co-authored-by: Denis Semenov <d.s.semenov@vkteam.ru> (cherry picked from commit 3212c31)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
convert_filters_to_predicatepublic in the DataFusion integration to allow external usage of the filter conversion logic.Are these changes tested?
pub use) and does not introduce new logic.