Skip to content

Add catalog test suite to unify catalog's behavior.#2131

Merged
blackmwk merged 9 commits intoapache:mainfrom
blackmwk:2086
Mar 12, 2026
Merged

Add catalog test suite to unify catalog's behavior.#2131
blackmwk merged 9 commits intoapache:mainfrom
blackmwk:2086

Conversation

@blackmwk
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

What changes are included in this PR?

In this pr we introduced catalog test suite in catalog-loader, which could unify the behavior of catalogs.

Are these changes tested?

Yes.

@blackmwk blackmwk requested review from CTTY, kevinjqliu and sdd and removed request for kevinjqliu February 10, 2026 03:35
@blackmwk blackmwk assigned Fokko and Xuanwo and unassigned Fokko and Xuanwo Feb 10, 2026
@blackmwk blackmwk requested review from Fokko and Xuanwo February 10, 2026 03:35
Copy link
Copy Markdown
Collaborator

@CTTY CTTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blackmwk for the PR! This makes the test code much easier to manage.

Just finished a round of review and left some comments

Comment thread crates/iceberg/src/catalog/memory/catalog.rs
Comment thread crates/catalog/glue/tests/glue_catalog_test.rs Outdated
Comment thread crates/catalog/rest/tests/rest_catalog_test.rs Outdated
Comment thread crates/catalog/hms/src/catalog.rs Outdated
Comment thread crates/catalog/hms/src/catalog.rs Outdated
Comment thread crates/catalog/hms/src/catalog.rs Outdated
Comment thread crates/catalog/hms/src/catalog.rs Outdated
Comment thread crates/catalog/loader/tests/namespace_suite.rs Outdated
Comment thread crates/catalog/loader/tests/namespace_suite.rs Outdated
Comment thread crates/catalog/sql/src/catalog.rs
Copy link
Copy Markdown
Collaborator

@CTTY CTTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blackmwk
Copy link
Copy Markdown
Contributor Author

cc @kevinjqliu @sdd @Xuanwo @Fokko PTAL

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, really great!

Comment thread crates/catalog/loader/tests/namespace_suite.rs Outdated
@blackmwk
Copy link
Copy Markdown
Contributor Author

cc @Xuanwo PTAL, I have addressed comments.

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@blackmwk blackmwk merged commit 335961a into apache:main Mar 12, 2026
20 checks passed
big-mac-slice pushed a commit to perpetualsystems/iceberg-rust that referenced this pull request Apr 2, 2026
## Which issue does this PR close?

- Closes apache#2086 .

## What changes are included in this PR?

In this pr we introduced catalog test suite in catalog-loader, which
could unify the behavior of catalogs.

## Are these changes tested?

Yes.

---------

Co-authored-by: Ray Liu <liurenjie2008@gmail.com>
toutane pushed a commit to DataDog/iceberg-rust that referenced this pull request Apr 23, 2026
## Which issue does this PR close?

- Closes apache#2086 .

## What changes are included in this PR?

In this pr we introduced catalog test suite in catalog-loader, which
could unify the behavior of catalogs.

## Are these changes tested?

Yes.

---------

Co-authored-by: Ray Liu <liurenjie2008@gmail.com>
(cherry picked from commit 335961a)
toutane pushed a commit to DataDog/iceberg-rust that referenced this pull request Apr 23, 2026
## Which issue does this PR close?

- Closes apache#2086 .

## What changes are included in this PR?

In this pr we introduced catalog test suite in catalog-loader, which
could unify the behavior of catalogs.

## Are these changes tested?

Yes.

---------

Co-authored-by: Ray Liu <liurenjie2008@gmail.com>
(cherry picked from commit 335961a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unified catalog test suite.

5 participants