feat!(catalog): adding support for purge_table#2232
Merged
blackmwk merged 14 commits intoapache:mainfrom Mar 25, 2026
Merged
Conversation
CTTY
commented
Mar 12, 2026
geruh
reviewed
Mar 14, 2026
CTTY
changed the title
blackmwk
reviewed
Mar 20, 2026
blackmwk
reviewed
Mar 24, 2026
geruh
reviewed
Mar 24, 2026
| async fn drop_table(&self, table: &TableIdent) -> Result<()> { | ||
| /// S3 Tables doesn't support soft delete, so dropping a table will permanently remove it from the catalog. | ||
| async fn drop_table(&self, _table: &TableIdent) -> Result<()> { | ||
| Err(Error::new( |
Member
There was a problem hiding this comment.
toutane
pushed a commit
to DataDog/iceberg-rust
that referenced
this pull request
Apr 23, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#2133 ## What changes are included in this PR? - Add catalog/utils.rs to provide helpers to delete table data using file_io and table_metadata - Add new API `purge_table` to `Catalog` trait and add default implementation - Implement purge_table for S3TableCatalog and RestCatalog <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? Added new tests in table_suite <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> (cherry picked from commit 56fda82)
toutane
pushed a commit
to DataDog/iceberg-rust
that referenced
this pull request
Apr 23, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#2133 ## What changes are included in this PR? - Add catalog/utils.rs to provide helpers to delete table data using file_io and table_metadata - Add new API `purge_table` to `Catalog` trait and add default implementation - Implement purge_table for S3TableCatalog and RestCatalog <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? Added new tests in table_suite <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> (cherry picked from commit 56fda82)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Catalog#2133What changes are included in this PR?
purge_tabletoCatalogtrait and add default implementationAre these changes tested?
Added new tests in table_suite