feat(iceberg): Add snapshot utils to scan ancestors#2285
Merged
blackmwk merged 4 commits intoapache:mainfrom Apr 1, 2026
Merged
feat(iceberg): Add snapshot utils to scan ancestors#2285blackmwk merged 4 commits intoapache:mainfrom
blackmwk merged 4 commits intoapache:mainfrom
Conversation
blackmwk
reviewed
Mar 25, 2026
t3hw
pushed a commit
to t3hw/iceberg-rust
that referenced
this pull request
Apr 14, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#2241 ## What changes are included in this PR? - Add `Ancestors` to help scan past snapshots - Moved existing util to the new utils mod <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? Yes <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
t3hw
pushed a commit
to t3hw/iceberg-rust
that referenced
this pull request
Apr 16, 2026
Promote `snapshot` to a top-level crate module (`crate::snapshot`) instead of nesting it under `util`. The `util` module reverts to a flat file now that it only contains `available_parallelism()`. Closes apache#2241 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
t3hw
added a commit
to t3hw/iceberg-rust
that referenced
this pull request
Apr 18, 2026
The `feat(iceberg): Add snapshot utils to scan ancestors (apache#2285)` feature already shipped in upstream main as `crate::util::snapshot`. This branch carried a structural variant placing `snapshot` at the crate root (`crate::snapshot`) with `util` as a flat `util.rs`. When rebasing `patched-0.9` onto a future release that includes apache#2285, upstream's `crate::util::snapshot` path would collide with our top-level layout. Move to upstream's layout ahead of time so the rebase is a clean fast-forward: crates/iceberg/src/snapshot.rs -> crates/iceberg/src/util/snapshot.rs crates/iceberg/src/util.rs -> crates/iceberg/src/util/mod.rs crates/iceberg/src/lib.rs -- drop `pub mod snapshot;` No in-crate code imports `crate::snapshot::*`, so no internal imports change. Downstream consumers of this fork that reference `iceberg::snapshot::*` must update to `iceberg::util::snapshot::*` and will be fixed out-of-band. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
toutane
pushed a commit
to DataDog/iceberg-rust
that referenced
this pull request
Apr 30, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#2241 ## What changes are included in this PR? - Add `Ancestors` to help scan past snapshots - Moved existing util to the new utils mod <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? Yes <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> (cherry picked from commit 626de2e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Ancestorsto help scan past snapshotsAre these changes tested?
Yes