fix(storage/s3): default to virtual-host-style addressing#2330
Merged
blackmwk merged 1 commit intoapache:mainfrom Apr 15, 2026
Merged
fix(storage/s3): default to virtual-host-style addressing#2330blackmwk merged 1 commit intoapache:mainfrom
blackmwk merged 1 commit intoapache:mainfrom
Conversation
plusplusjiajia
force-pushed
the
fix/s3-default-virtual-host-style
branch
from
00b10ab to
3d843c5
Compare
blackmwk
approved these changes
Apr 15, 2026
Contributor
blackmwk
left a comment
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @plusplusjiajia for this fix!
toutane
pushed a commit
to DataDog/iceberg-rust
that referenced
this pull request
Apr 30, 2026
## Which issue does this PR close? N/A ## What changes are included in this PR? The Java Iceberg SDK defaults [`s3.path-style-access` to `false`](https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java#L238-L240) i.e. virtual-host-style addressing is the spec default. opendal's `S3Config::default()`, which the opendal storage backend inherits from, uses path-style. As a result, any user building an iceberg-rust `FileIO` against AWS S3 or an S3-compatible service has to explicitly set `s3.path-style-access=false` to get the same behavior they would get from Java out of the box — and several S3-compatible endpoints only accept virtual-host-style URLs and fail outright with `SecondLevelDomainForbidden` (or equivalent) under the current default. ## Are these changes tested? Yes: - `cargo test -p iceberg --lib io::storage::config::s3::tests` - `cargo test -p iceberg-storage-opendal --lib s3::tests (cherry picked from commit d6692fc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
What changes are included in this PR?
The Java Iceberg SDK defaults
s3.path-style-accesstofalsei.e. virtual-host-style addressing is the spec default. opendal'sS3Config::default(), which the opendal storage backend inherits from, uses path-style. As a result, any user building an iceberg-rustFileIOagainst AWS S3 or an S3-compatible service has to explicitly sets3.path-style-access=falseto get the same behavior they would get from Java out of the box — and several S3-compatible endpoints only accept virtual-host-style URLs and fail outright withSecondLevelDomainForbidden(or equivalent) under the current default.Are these changes tested?
Yes:
cargo test -p iceberg --lib io::storage::config::s3::tests