feat(datafusion): show pushed-down limit in IcebergTableScan EXPLAIN output#2360
Merged
blackmwk merged 2 commits intoapache:mainfrom Apr 23, 2026
Merged
Conversation
blackmwk
approved these changes
Apr 23, 2026
toutane
added a commit
to DataDog/iceberg-rust
that referenced
this pull request
Apr 29, 2026
…output (apache#2360) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#2359. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> Emit ` limit:[N]` in `IcebergTableScan`'s `DisplayAs` output when a `LIMIT` is pushed down to the scan. When no limit is pushed down, the output is unchanged. - Before (unchanged): `IcebergTableScan projection:[id,name] predicate:[...]` - After (new, only when a limit reaches the scan): `IcebergTableScan projection:[...] predicate:[] limit:[3]` ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes: new `EXPLAIN ... LIMIT 3` assertion in `crates/sqllogictest/testdata/slts/df_test/basic_queries.slt`. Existing snapshots are unchanged, which confirms the additive-only behavior. (cherry picked from commit c82c42e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
limitinIcebergTableScanEXPLAIN output when pushed down #2359.What changes are included in this PR?
Emit
limit:[N]inIcebergTableScan'sDisplayAsoutput when aLIMITis pushed down to the scan. When no limit is pushed down, the output is unchanged.Before (unchanged):
IcebergTableScan projection:[id,name] predicate:[...]After (new, only when a limit reaches the scan):
IcebergTableScan projection:[...] predicate:[] limit:[3]Are these changes tested?
Yes: new
EXPLAIN ... LIMIT 3assertion incrates/sqllogictest/testdata/slts/df_test/basic_queries.slt. Existing snapshots are unchanged, which confirms the additive-only behavior.