Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented Jun 11, 2024

Project supports building with 8, 11 and 17. In most CI scripts we run the jobs on all supported Java versions, let's do same here to ensure the build would work locally too.

Relates to: #10477

Project supports building with 8, 11 and 17. In most CI scripts we run
the jobs on all supported Java versions, let's do same here to ensure
the build would work locally too.
@findepi findepi force-pushed the findepi/run-hive3-tests-on-java-11-and-17-too-34b7c8 branch from 1424392 to 3577dd0 Compare June 11, 2024 11:56
@findepi
Copy link
Member Author

findepi commented Jun 17, 2024

if we don't want to run on all Java versions, i'd recommend running at least on the oldest and newest versions supposed to be supported.

cc @Fokko @nastra

runs-on: ubuntu-22.04
strategy:
matrix:
jvm: [8, 11, 17]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is same as above for hive2-tests.

@findepi findepi requested a review from nastra June 18, 2024 14:58
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the Hive3 tests run in 1 minute. With Hive 4 Iceberg integration will be native in Hive, so these jobs will removed at some point. Thanks again @findepi for the PR and @jbonofre for the review 👍

@Fokko Fokko merged commit 10d7ab1 into apache:main Jun 19, 2024
@findepi findepi deleted the findepi/run-hive3-tests-on-java-11-and-17-too-34b7c8 branch June 19, 2024 18:25
@findepi
Copy link
Member Author

findepi commented Jun 19, 2024

good to know about the future of Hive Iceberg integration 👍
and thanks for all review comments!

jasonf20 pushed a commit to jasonf20/iceberg that referenced this pull request Aug 4, 2024
Project supports building with 8, 11 and 17. In most CI scripts we run
the jobs on all supported Java versions, let's do same here to ensure
the build would work locally too.
sasankpagolu pushed a commit to sasankpagolu/iceberg that referenced this pull request Oct 27, 2024
Project supports building with 8, 11 and 17. In most CI scripts we run
the jobs on all supported Java versions, let's do same here to ensure
the build would work locally too.
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
Project supports building with 8, 11 and 17. In most CI scripts we run
the jobs on all supported Java versions, let's do same here to ensure
the build would work locally too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants