-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Core: Upgrade Jetty to 12.1.5 #10837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,13 +107,8 @@ project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") { | |
| testImplementation project(path: ':iceberg-api', configuration: 'testArtifacts') | ||
| testImplementation project(path: ':iceberg-core', configuration: 'testArtifacts') | ||
| testImplementation project(path: ':iceberg-data', configuration: 'testArtifacts') | ||
| testImplementation (project(path: ':iceberg-open-api', configuration: 'testFixturesRuntimeElements')) { | ||
| transitive = false | ||
| } | ||
| testImplementation libs.sqlite.jdbc | ||
| testImplementation (project(path: ':iceberg-open-api', configuration: 'testFixturesRuntimeElements')) | ||
| testImplementation libs.awaitility | ||
| // runtime dependencies for running REST Catalog based integration test | ||
| testRuntimeOnly libs.jetty.servlet | ||
| } | ||
|
|
||
| test { | ||
|
|
@@ -174,13 +169,7 @@ project(":iceberg-spark:iceberg-spark-extensions-${sparkMajorVersion}_${scalaVer | |
| testImplementation project(path: ':iceberg-core', configuration: 'testArtifacts') | ||
| testImplementation project(path: ':iceberg-hive-metastore', configuration: 'testArtifacts') | ||
| testImplementation project(path: ":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}", configuration: 'testArtifacts') | ||
| testImplementation (project(path: ':iceberg-open-api', configuration: 'testFixturesRuntimeElements')) { | ||
| transitive = false | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this was initially done because there were conflicts. However, given that we don't have any conflicts anymore we can remove this |
||
| } | ||
| // runtime dependencies for running REST Catalog based integration test | ||
| testRuntimeOnly libs.jetty.servlet | ||
| testRuntimeOnly libs.sqlite.jdbc | ||
|
|
||
| testImplementation (project(path: ':iceberg-open-api', configuration: 'testFixturesRuntimeElements')) | ||
| testImplementation libs.avro.avro | ||
| testImplementation libs.parquet.hadoop | ||
| testImplementation libs.awaitility | ||
|
|
@@ -272,11 +261,7 @@ project(":iceberg-spark:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersio | |
| integrationRuntimeOnly project(':iceberg-hive-metastore') | ||
| // runtime dependencies for running REST Catalog based integration test | ||
| integrationRuntimeOnly project(path: ':iceberg-core', configuration: 'testArtifacts') | ||
| integrationRuntimeOnly (project(path: ':iceberg-open-api', configuration: 'testFixturesRuntimeElements')) { | ||
| transitive = false | ||
| } | ||
| integrationRuntimeOnly libs.jetty.servlet | ||
| integrationRuntimeOnly libs.sqlite.jdbc | ||
| integrationRuntimeOnly (project(path: ':iceberg-open-api', configuration: 'testFixturesRuntimeElements')) | ||
|
|
||
| // Not allowed on our classpath, only the runtime jar is allowed | ||
| integrationCompileOnly project(":iceberg-spark:iceberg-spark-extensions-${sparkMajorVersion}_${scalaVersion}") | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -155,7 +155,7 @@ private void runBenchmark(RowLevelOperationMode mode, double updatePercentage) { | |
| private void setupSpark() { | ||
| this.spark = | ||
| SparkSession.builder() | ||
| .config("spark.ui.enabled", false) | ||
| .config(TestBase.DISABLE_UI) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The main issue with Spark is that Spark brings its own (older) Jetty version for the UI, which conflicts with the Jetty version we're using. The downside is that we need to disable the UI pretty much everywhere
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Spark only upgraded to jetty 12 after 4.2, so I believe it's worthwhile. As a follow-up, I plan to create a util method to start
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this mean it's going to be an issue for downstream users? If not why don't we switch these benchmarks to use the fat jar? |
||
| .config("spark.sql.extensions", IcebergSparkSessionExtensions.class.getName()) | ||
| .config("spark.sql.catalog.spark_catalog", SparkSessionCatalog.class.getName()) | ||
| .config("spark.sql.catalog.spark_catalog.type", "hadoop") | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed because
GzipHandleris now deprecated. We'll be switching to Jetty's new Compression API in #15043