Add a tolerance check of 1 minute to prevent small clock skews to break commits #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ak commits Fixes 1109 squash! 1109 Add a tolerance check of 1 minute to prevent small clock skews to break commits
rdblue
reviewed
Jun 12, 2020
Contributor
|
Looks good, but I think we also need to update handling for the snapshot history log. |
rdsr
commented
Jun 12, 2020
rdblue
reviewed
Jun 13, 2020
rdblue
reviewed
Jun 13, 2020
| } | ||
| last = logEntry; | ||
| } | ||
| if (last != null) { |
Contributor
There was a problem hiding this comment.
Rather than wrapping a precondition in an if, it's shorter to add an or:
Preconditions.checkArgument(last == null || lastUpdatedMillis - last.timestampMillis() >= -ONE_MINUTE, ...);
Contributor
Author
There was a problem hiding this comment.
The issue is that the argument - last.timestampMillis() will be evaluated eagerly and may result in NPE
Contributor
There was a problem hiding this comment.
It shouldn't be evaluated eagerly. Are you sure about that? We use this pattern in other classes without a problem.
Contributor
Author
|
@rdblue can you have another look please? |
rdblue
reviewed
Jun 15, 2020
| } | ||
| previous = metadataEntry; | ||
| } | ||
| // Make sure that this update's lastUpdatedMillis is > max(previousFile's timestamp) |
Contributor
|
Overall it looks good. Thanks, @rdsr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1109