Added curl to the iceberg rest fixture Docker image #11688 #11705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikhei
changed the title
Contributor
|
@dominikhei Thanks for working on this. As you already suggested, it would be good to also clean up afterward, see best practices of Docker: https://docs.docker.com/build/building/best-practices/#apt-get |
Contributor
Author
|
@Fokko I updated the PR! |
Contributor
|
@dominikhei if we're going to add curl, shouldn't we setup the healthcheck as well? It seems like it would make sense to tie this addition with its usage. |
Contributor
Author
|
@danielcweeks let me know if it is fine if I just probe the |
Fokko
reviewed
Dec 6, 2024
Contributor
Author
|
@Fokko Sorry, I did not see your message so far, thank you for the detailed explanation. I there anything left to do? |
Fokko
approved these changes
Dec 9, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
@dominikhei No, this all looks good, thanks for working on this @dominikhei 🙌
Fokko
added a commit
to Fokko/iceberg-rust
that referenced
this pull request
Dec 9, 2024
- Switch to the `apache/iceberg-rest-fixture` - That contains now a healthcheck: apache/iceberg#11705 - Update docs to point to Orbstack, native Docker doesn't work (today)
Fokko
added a commit
to Fokko/iceberg-rust
that referenced
this pull request
Dec 9, 2024
- Switch to the `apache/iceberg-rest-fixture` - That contains now a healthcheck: apache/iceberg#11705 - Update docs to point to Orbstack, native Docker doesn't work (today)
Fokko
added a commit
to Fokko/iceberg-rust
that referenced
this pull request
Dec 9, 2024
- Switch to the `apache/iceberg-rest-fixture` - That contains now a healthcheck: apache/iceberg#11705 - Update docs to point to Orbstack, native Docker doesn't work (today)
Fokko
added a commit
to Fokko/iceberg-rust
that referenced
this pull request
Dec 9, 2024
- Switch to the `apache/iceberg-rest-fixture` - That contains now a healthcheck: apache/iceberg#11705 - Update docs to point to Orbstack, native Docker doesn't work (today)
liurenjie1024
pushed a commit
to apache/iceberg-rust
that referenced
this pull request
Dec 10, 2024
- Switch to the `apache/iceberg-rest-fixture` - That contains now a healthcheck: apache/iceberg#11705 - Update docs to point to Orbstack, native Docker doesn't work (today)
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
* Added command to install curl * Added command to cleanup apt cache * Added health probing * Update healthcheck --------- Co-authored-by: Fokko Driesprong <fokko@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11688
I have added curl to the docker image. If you want me to adjust the contribution in any way, e.g to also clean up the package cache to save space, let me know.