Core: Use HEAD request to check if view exists #11760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
nastra
force-pushed
the
view-exists-via-head-request
branch
from
5532738 to
f0e9f50
Compare
Fokko
approved these changes
Dec 12, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for adding this @nastra
Spec ref:
iceberg/open-api/rest-catalog-open-api.yaml
Line 1691 in 6c05f35
ebyhr
approved these changes
Dec 12, 2024
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Could we add a test to TestRESTCatalog that makes sure the client is issuing a head request when checking if a view exists? Other than that the changes themselves look good to me
nastra
force-pushed
the
view-exists-via-head-request
branch
from
f0e9f50 to
bc08ae4
Compare
Contributor
Author
|
@amogh-jahagirdar good point, I've added a test to |
amogh-jahagirdar
approved these changes
Dec 12, 2024
This was referenced Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.