Core: Fix tests around empty namespaces #11962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
fix-empty-ns-tests
branch
from
b49e1b8 to
1aeeb8a
Compare
Contributor
Author
|
Actually I think #11960 is the better fix for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bisected this and looked why this test started to fail after it was merged to main. The reason is that with #11761 we changed namespace existence check for the REST catalog, which in turn does a namespace validation check. Prior to #11761 that validation error would be caught in
iceberg/api/src/main/java/org/apache/iceberg/catalog/SupportsNamespaces.java
Line 161 in 1ea1852