Fix test timeout by logging tests that pass #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 We can also enable this just for CI so that local builds don't get affected with the noise. See shardulm94@bf906c4 |
rdsr
approved these changes
Jul 15, 2020
Contributor
Author
|
I'm merging this to get CI back working. @shardulm94, your patch looks good to me as a follow-up if you want to remove the noise. |
HotSushi
pushed a commit
to HotSushi/iceberg
that referenced
this pull request
Jul 23, 2020
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements option 4 from #1198. Each passing test case will be logged so that Travis CI gets updates that tests are still running.