Merged
Conversation
manuzhang
commented
Feb 24, 2025
nastra
reviewed
Feb 24, 2025
| for (int i = 0; i < actual.numFields(); i += 1) { | ||
| StructField field = struct.fields()[i]; | ||
| DataType type = field.dataType(); | ||
| // ColumnarRow.get doesn't support TimestampNTZType, causing tests to fail. the representation |
Contributor
There was a problem hiding this comment.
thanks for removing this. This also fixes #11945
pan3793
reviewed
Feb 25, 2025
omkenge
approved these changes
Feb 25, 2025
manuzhang
force-pushed
the
upgrade-spark3.5
branch
from
c13e990 to
7b5096c
Compare
nastra
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11945