Skip to content

Conversation

@manuzhang
Copy link
Member

@manuzhang manuzhang commented Apr 16, 2025

As suggested by @rdblue in #12767 (comment)

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems super large compared to just update Parquet version on a release branch 😄
As a kind of temporary cleanup waiting tool.

I still believe it's better to keep the version, at least for MIT/BSD dependency.

Removing the version for ALv2 dependencies is ok, but I would keep for MIT/BSD.

@manuzhang
Copy link
Member Author

I used a regex to remove all at once. It will be challenging to just remove ALv2 😂.

I'll send another PR to update parquet versions and let community to decide which way to go.

@jbonofre
Copy link
Member

@manuzhang so to be clear, rethinking about that, I think we should keep the versions. According to my comment here (#12730 (comment)), the version is a good documentation, as the version in our dependencies is not the version in the bundle artifact (as version can come from transitive).
I have the PR ready for main and 1.9.x branches. I'm happy to do that for 1.8.x too.
Imho, the release manager should check the version before release (it took me 10mn and I can share the script using dependency version check).

@jbonofre
Copy link
Member

Superseeded by #12834

@jbonofre
Copy link
Member

#12834 has been merged and 1.8.x is clean now. I would suggest to close this PR.

@manuzhang manuzhang closed this Apr 18, 2025
@manuzhang manuzhang deleted the remove-LICENSE-version branch May 7, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants