Flink: Change Preconditions import from flink util to guava#12939
Merged
pvary merged 1 commit intoapache:mainfrom Apr 30, 2025
Merged
Flink: Change Preconditions import from flink util to guava#12939pvary merged 1 commit intoapache:mainfrom
pvary merged 1 commit intoapache:mainfrom
Conversation
pvary
approved these changes
Apr 30, 2025
ebyhr
approved these changes
Apr 30, 2025
Contributor
Author
|
@pvary Do you have any idea about the CI failure? Will run CI again can fix this ? I think the connection with port is not about this change. |
Contributor
|
Probably caused by this: #12009 |
nastra
approved these changes
Apr 30, 2025
Contributor
|
Thanks @Guosmilesmile for the PR and @nastra and @ebyhr for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussion in #11497 (comment) , we should replace all of the
org.apache.flink.util.Preconditionsimports toorg.apache.iceberg.relocated.com.google.common.base.Preconditionsin the already existing Flink classes . And update the checkstyle.xml to prevent this class to be imported again