Skip to content

Flink: Change Preconditions import from flink util to guava#12939

Merged
pvary merged 1 commit intoapache:mainfrom
Guosmilesmile:change_import
Apr 30, 2025
Merged

Flink: Change Preconditions import from flink util to guava#12939
pvary merged 1 commit intoapache:mainfrom
Guosmilesmile:change_import

Conversation

@Guosmilesmile
Copy link
Contributor

As discussion in #11497 (comment) , we should replace all of the org.apache.flink.util.Preconditions imports to org.apache.iceberg.relocated.com.google.common.base.Preconditions in the already existing Flink classes . And update the checkstyle.xml to prevent this class to be imported again

@Guosmilesmile
Copy link
Contributor Author

Guosmilesmile commented Apr 30, 2025

@pvary Do you have any idea about the CI failure? Will run CI again can fix this ? I think the connection with port is not about this change.

TestRewritePositionDeleteFilesAction > initializationError FAILED
    java.io.IOException: Failed to bind to 0.0.0.0/0.0.0.0:33727
        at org.eclipse.jetty.server.ServerConnector.openAcceptChannel(ServerConnector.java:344)
        at org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:304)
        at org.eclipse.jetty.server.Server.lambda$doStart$0(Server.java:402)

 Caused by:
        java.net.BindException: Address already in use
            at java.base/sun.nio.ch.Net.bind0(Native Method)
            at java.base/sun.nio.ch.Net.bind(Net.java:555)
            at java.base/sun.nio.ch.ServerSocketChannelImpl.netBind(ServerSocketChannelImpl.java:337)
            at java.base/sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:294)
            at org.eclipse.jetty.server.ServerConnector.openAcceptChannel(ServerConnector.java:339)
            ... 17 more

@pvary
Copy link
Contributor

pvary commented Apr 30, 2025

Probably caused by this: #12009
Restarted the failed tests.

@pvary pvary merged commit 5ac1942 into apache:main Apr 30, 2025
42 checks passed
@pvary
Copy link
Contributor

pvary commented Apr 30, 2025

Thanks @Guosmilesmile for the PR and @nastra and @ebyhr for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants