Flink: Backport #12996 to Flink 1.19 / 1.20#13246
Merged
pvary merged 2 commits intoapache:mainfrom Jun 5, 2025
Merged
Conversation
This backports apache#12996 to Flink versions 1.19. Patch applied cleanly, apart from re-adding a 2.0 removed interface method in DynamicRecordInternalSerializer.
This backports apache#12996 to Flink versions 1.20. Patch applied cleanly, apart from re-adding a 2.0 removed interface method in DynamicRecordInternalSerializer.
mxm
commented
Jun 5, 2025
Comment on lines
+78
to
+82
| @Override | ||
| public TypeSerializer<DynamicRecordInternal> createSerializer(ExecutionConfig executionConfig) { | ||
| return new DynamicRecordInternalSerializer( | ||
| new TableSerializerCache(catalogLoader, cacheSize), writeSchemaAndSpec); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This method was added. It has been removed in Flink 2.0.
Comment on lines
+78
to
+82
| @Override | ||
| public TypeSerializer<DynamicRecordInternal> createSerializer(ExecutionConfig executionConfig) { | ||
| return new DynamicRecordInternalSerializer( | ||
| new TableSerializerCache(catalogLoader, cacheSize), writeSchemaAndSpec); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This method was added. It has been removed in Flink 2.0.
pvary
approved these changes
Jun 5, 2025
Contributor
|
Merged to main. |
cogwirrel
pushed a commit
to cogwirrel/iceberg
that referenced
this pull request
Aug 10, 2025
…cordInternalSerializer to Flink 1.19 / 1.20 (apache#13246) backports apache#12996
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
…cordInternalSerializer to Flink 1.19 / 1.20 (apache#13246) backports apache#12996
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #12996 to Flink versions 1.19 / 1.20. Patch applied cleanly, apart from
re-adding a 2.0 removed interface method in DynamicRecordInternalSerializer. I'm highlighting the change inline.