Flink: Dynamic Iceberg Sink: Add sink / core processing logic / benchmarking#13304
Merged
pvary merged 15 commits intoapache:mainfrom Jun 17, 2025
Merged
Flink: Dynamic Iceberg Sink: Add sink / core processing logic / benchmarking#13304pvary merged 15 commits intoapache:mainfrom
pvary merged 15 commits intoapache:mainfrom
Conversation
pvary
reviewed
Jun 12, 2025
| } | ||
|
|
||
| @Test | ||
| void testUpsert() throws Exception { |
Contributor
There was a problem hiding this comment.
Maybe some tests with state restore?
Contributor
There was a problem hiding this comment.
Also, can we have a check were there is concurrent insert to one of the tables we are writing to?
Contributor
There was a problem hiding this comment.
Do we have a test where there is a concurrent commit to one of the tables by a different sink, or application?
Contributor
Author
There was a problem hiding this comment.
I've added a test to fail before / after commit, and one for concurrent commits: 3ef4d87.
Do we have a test where there is a concurrent commit to one of the tables by a different sink, or application?
Not yet.
pvary
reviewed
Jun 12, 2025
pvary
reviewed
Jun 16, 2025
pvary
reviewed
Jun 16, 2025
pvary
reviewed
Jun 16, 2025
pvary
reviewed
Jun 16, 2025
pvary
reviewed
Jun 16, 2025
pvary
reviewed
Jun 16, 2025
pvary
approved these changes
Jun 17, 2025
Contributor
|
Merged to main. |
Contributor
Author
|
Thanks for reviewing / merging @pvary! |
mxm
added a commit
to mxm/iceberg
that referenced
this pull request
Jun 18, 2025
mxm
added a commit
to mxm/iceberg
that referenced
this pull request
Jun 18, 2025
eric-maynard
pushed a commit
to eric-maynard/iceberg
that referenced
this pull request
Jun 18, 2025
eric-maynard
pushed a commit
to eric-maynard/iceberg
that referenced
this pull request
Jun 18, 2025
…c / benchmarking to Flink 1.19 / 1.20 (apache#13341) backports apache#13304
cogwirrel
pushed a commit
to cogwirrel/iceberg
that referenced
this pull request
Aug 10, 2025
…c / benchmarking to Flink 1.19 / 1.20 (apache#13341) backports apache#13304
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
…c / benchmarking to Flink 1.19 / 1.20 (apache#13341) backports apache#13304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the breakdown of #12424. Most importantly, it adds the following missing components:
DynamicIcebergSink
The actual Flink sink which ties together the previously merged components. The sink will be instantiated by the user like this:
An example for a converter implementation would be:
DynamicRecordProcessor
The core processing logic which takes user-provided input to write to Iceberg tables and make the necessary changes to the Iceberg metadata.
Benchmarks
Previous PRs
The following previous PRs have been merged already: