Conversation
| // Query and validate | ||
| List<Object[]> actual = sql("SELECT * FROM %s", tableName); | ||
| for (int i = 0; i < expected.size(); i++) { | ||
| System.out.println(actual.get(i)[0]); |
| List<Object[]> actual = sql("SELECT * FROM %s", tableName); | ||
| for (int i = 0; i < expected.size(); i++) { | ||
| System.out.println(actual.get(i)[0]); | ||
| assertEquals("Mismatch at row " + i, expected, actual); |
There was a problem hiding this comment.
Are you comparing row by row?
assertEquals("Mismatch at row " + i, expected.get(i)[0], actual.get(i)[0]);
| @TestTemplate | ||
| public void testDecimalColumn() { | ||
| int rows = 100; | ||
| String tableName = tableName("decimal_table1"); |
There was a problem hiding this comment.
Shall we use the class level field this.tableName instead?
this.tableName = tableName("decimal_table1");
then we will have the @AfterEach cleanup
sql("DROP TABLE IF EXISTS %s", tableName)
There was a problem hiding this comment.
I think if we switch to class level field this.tableName, then we don't need the TRUNCATE TABLE below.
|
Thanks @hsiang-c for the PR! The PR looks good overall. I have a couple of minor comments. Could you please also add a brief description of this PR? |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
|
||
| @TestTemplate | ||
| public void testDecimalColumn() { | ||
| int rows = 100; |
There was a problem hiding this comment.
It would be good to try some other values - The range of integers between 513 and 1024 is likely to show a mismatch between the byte array base dBigInteger/BigDecimal encoding and the 128 bit native integer.
3 participants
No description provided.