Core, API: Report metrics about deleted files in ExpireSnapshots #14921
+335
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
force-pushed
the
raunaq/expire-snapshots-report
branch
6 times, most recently
from
81eea28 to
da13abd
Compare
singhpk234
reviewed
Dec 26, 2025
| import org.immutables.value.Value; | ||
|
|
||
| @Value.Immutable | ||
| public abstract class RemoveSnapshotsReport implements MetricsReport { |
Contributor
There was a problem hiding this comment.
i wonder if there is a way to get this according to the contract defined here :
Contributor
Author
There was a problem hiding this comment.
I wanted to use MetricsReporter as that is a more flexible approach and similar to org.apache.iceberg.Scan#metricsReporter
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
raunaq/expire-snapshots-report
branch
from
da13abd to
e6c8161
Compare
raunaqmorarka
force-pushed
the
raunaq/expire-snapshots-report
branch
4 times, most recently
from
6aafe27 to
37c631d
Compare
raunaqmorarka
force-pushed
the
raunaq/expire-snapshots-report
branch
from
37c631d to
c21feaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpireSnapshots currently does not expose metrics about the operations performed by it to the caller.
This change allows the caller to collect metrics about deleted data, position deletes, equality deletes, manifest lists, manifests and statistics files.
This is needed to allow Trino to show an output similar to https://iceberg.apache.org/docs/latest/spark-procedures/#output_6 when running expire_snaphots procedure in Trino.