Core: HadoopFileIO to take list of filesystem schemas to enable trash for #15111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* declares whether to look @ trash policy before delete * defaults are currently "hdfs" and "viewfs", though I'm tempted to make the default "".
… for Addresses apache#15093 * Default Filesystems are hdfs: and viewfs: schemas * Tests conditionally enable file: schema as trash * Tests set up FS with/without trash enablement. * Also address issue that delete(missing-path) must always succeed; trash policy fails here.
+ docs. + test sets in a list of schemas when enabling local trash so verifying that the option splitting works.
1. verify setting schemas to "" means default hdfs value goes 2. verify that a failure in moveToTrash() is caught and downgraded. Test case apache#2 is the key one, as it shows that delete works even if trash move somehow failed. + fix doc trailing space failure.
This was referenced Jan 27, 2026
Contributor
Author
|
Interesting issue here: ~/.Trash gets big, though it'll need more investigation to make sure this isn't from interrupted tests. There's no way to set a different trash root; these will need cleaning up. |
* the explicit trash tests clean up their trash paths; this verifies that attempts to delete under .Trash use delete() instead. * user trash root is cleaned up after tests. Side issue: the path is always /user/$USER/.Trash, even on Linux local filesystems. Does that work reliably?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15093
active trash policy.
Doc changes are at the bottom of fileio.md
I added Adls gen2/abfs on the list of filesystems too, as it was missing & the code for it is there.