chore: several fixes on the LICENSE/NOTICE#15449
chore: several fixes on the LICENSE/NOTICE#15449RussellSpitzer merged 13 commits intoapache:mainfrom
Conversation
jbonofre
commented
Feb 26, 2026
jbonofre
commented
- Important fixes
- include BSD/MIT license content inline in all LICENSE files
- update copyright year to 2026
- select a single license (when dual) in all LICENSE files
- remove dependency versions to relax the updates (dependabot)
- Minor fixes
- Use the "This product bundles"/"This product includes code" wording everywhere
- Use the same AL v2 license wording everywhere
* Important fixes ** include BSD/MIT license content inline in all LICENSE files ** update copyright year to 2026 ** select a single license (when dual) in all LICENSE files ** remove dependency versions to relax the updates (dependabot) * Minor fixes ** Use the "This product bundles"/"This product includes code" wording everywhere ** Use the same AL v2 license wording everywhere
jbonofre
changed the title
|
I'm also doing a full pass on the dependencies use. |
|
@manuzhang I saw several missing dependencies missing in LICENSEs (flink-runtime, ...). I'm doing a full pass. It seems the GCP (BigQuery, ...) support added several dependencies but the |
|
Is there a tool that can check whether license info of dependencies is missing? |
|
@manuzhang I have scripts (using |
- Reactive Streams: correct license label from MIT to MIT-0 (MIT No Attribution is a distinct SPDX identifier) - Findbugs jsr305: correct license from Apache 2.0 to BSD 3-Clause with inline text (per the project's own LICENSE file) - Google API Common/GAX/Auth Library: use BSD 3-Clause consistently in kafka-connect bundles to match gcp-bundle and actual repo LICENSE files - Jackson: update dead codehaus.org URL to github.com/FasterXML/jackson - Fix typos: "bt" -> "by", "prodduct" -> "product", "produt" -> "product" - Remove empty section artifact in azure-bundle LICENSE - Remove duplicate Animal Sniffer Annotations line in flink LICENSE files Made-with: Cursor
There was a problem hiding this comment.
Detailed review comments have been moved to the fix PR: jbonofre#1 (comment)
|
Had Cursor go through and take a look for any discrepancies, they are in the PR above^ |
|
I just updated the PR to have all fixes there. |
|
@RussellSpitzer @manuzhang I completed the full pass and fixes on all |
| License (from POM): The Apache Software License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt | ||
|
|
||
| -------------------------------------------------------------------------------- | ||
| This product bundles Android Annotations. |
There was a problem hiding this comment.
This dependency looks strange to me.
There was a problem hiding this comment.
In the kafka-connect runtime distribution (zip file), you can find lib/annotations-4.1.1.4.jar corresponding to this artifact: https://repo1.maven.org/maven2/com/google/android/annotations/4.1.1.4/
That's the reason why we have to "document" it in the LICENSE file.
| Group: org.reactivestreams Name: reactive-streams Version: 1.0.4 | ||
| Project URL: http://reactive-streams.org | ||
| License: CC0 - http://creativecommons.org/publicdomain/zero/1.0/ | ||
| License: MIT |
There was a problem hiding this comment.
Do we need this to be MIT-0 ?
There was a problem hiding this comment.
This got flagged in azure-bundle, kafka-connect/main and kafka-connect/hive
There was a problem hiding this comment.
According to https://github.com/reactive-streams/reactive-streams-jvm it's a MIT licenses, but https://github.com/reactive-streams/reactive-streams-io/blob/master/LICENSE is for reactive streams IO.
We are using reactive steams JVM according to the packaged artifacts/classes.
There was a problem hiding this comment.
The problem is that line 245 states this is MIT-0 and not MIT
So either we have the copyright text wrong below or we have the SPDX wrong
|
|
||
| This product bundles Google GAX. | ||
|
|
||
| -------------------------------------------------------------------------------- |
There was a problem hiding this comment.
This separator belongs on line 678 (Same issue in other spark bundles)
|
Not sure if it matters but all the jackson links still point to codehaus which is a dead link now |
|
@manuzhang @RussellSpitzer I addressed your comments. Thanks ! |
|
Thanks @jbonofre ! Also thanks @manuzhang for reviewing |
3 participants
