Spark: Remove Apache DataFusion Comet integration#15674
Merged
huaxingao merged 3 commits intoapache:mainfrom Mar 18, 2026
Merged
Spark: Remove Apache DataFusion Comet integration#15674huaxingao merged 3 commits intoapache:mainfrom
huaxingao merged 3 commits intoapache:mainfrom
Conversation
Removes the datafusion-comet dependency and all related code across Spark versions 3.4, 3.5, 4.0, and 4.1. This includes the Comet-specific vectorized reader classes, ParquetReaderType enum, the spark.sql.iceberg.parquet.reader-type configuration property, and associated build/test infrastructure.
andygrove
force-pushed
the
remove-comet-dependency
branch
from
c8b5546 to
0c24239
Compare
Member
Author
huaxingao
approved these changes
Mar 18, 2026
Contributor
huaxingao
left a comment
huaxingao
left a comment
There was a problem hiding this comment.
LGTM. Thanks @andygrove
anuragmantri
approved these changes
Mar 18, 2026
Contributor
anuragmantri
left a comment
anuragmantri
left a comment
There was a problem hiding this comment.
LGTM, thanks @andygrove
huaxingao
changed the title
Contributor
|
Thanks @andygrove and @anuragmantri |
manuzhang
pushed a commit
to manuzhang/iceberg
that referenced
this pull request
Mar 30, 2026
* Spark: Remove Apache DataFusion Comet integration Removes the datafusion-comet dependency and all related code across Spark versions 3.4, 3.5, 4.0, and 4.1. This includes the Comet-specific vectorized reader classes, ParquetReaderType enum, the spark.sql.iceberg.parquet.reader-type configuration property, and associated build/test infrastructure. * spotless * update test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The current Comet integration is broken due to shading issues and it depends on code in Comet that is deprecated.
There was an effort to fix these issues, but Comet is now focussing on integrating with the Rust implementation of Iceberg, so we would like to remove the integration from the Java implementation.
Changes
Removes the datafusion-comet dependency and all related code across Spark versions 3.4, 3.5, 4.0, and 4.1. This includes the Comet-specific vectorized reader classes, ParquetReaderType enum, the spark.sql.iceberg.parquet.reader-type configuration property, and associated build/test infrastructure.