Parquet: Fix NPE in ParquetAvroWriter when schema contains variant type#15934
Merged
huaxingao merged 6 commits intoapache:mainfrom Apr 13, 2026
Merged
Parquet: Fix NPE in ParquetAvroWriter when schema contains variant type#15934huaxingao merged 6 commits intoapache:mainfrom
huaxingao merged 6 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Fixes for the runtime deps and zizmor is #15937. That would need to be merged and I'll rebase after it to get the tests to pass. |
Contributor
Author
krvikash
approved these changes
Apr 12, 2026
Contributor
krvikash
left a comment
There was a problem hiding this comment.
Can we squash the commits in a single commit?
huaxingao
reviewed
Apr 12, 2026
singhpk234
approved these changes
Apr 12, 2026
Contributor
Author
|
Thank you @huaxingao and @singhpk234 for your reviews. |
Contributor
|
Thanks @nssalian for the PR! Thanks @singhpk234 @krvikash @steveloughran for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #15933
ParquetAvroWriter.WriteBuilderinheritsParquetTypeVisitor.variant()which returnsnull. For OPTIONAL variant fields,struct()wraps this null inOptionWriter, which dereferenceswriter.columns()resulting in an NPEChanges
Override
variant()to throwUnsupportedOperationException, similar toprimitive()handles unsupported types in the same class.Test plan
UnsupportedOperationExceptionand ran it locally.ParquetAvroWriterand verified the NPE is reproducible.