Remove deprecated BaseMetastoreCatalog.dropTableData #1841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvary
force-pushed
the
removedeprecated
branch
from
25b937d to
4612227
Compare
Contributor
Author
|
@rdblue or @shardulm94: Could you please check this out after Thanksgiving? |
Contributor
|
Thanks for remembering to do this! Always good to remove deprecated methods when we can. |
Contributor
Author
To be honest, I forgot this one too, but stumbled upon the code accidentally 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed we should deprecate this in 0.11.0:
Because this was
protected, I think we should keep it and just delegate to where the method moved. We can also deprecated it and set a version when it will be removed:Originally posted by @rdblue in #1481 (comment)