Revert "AWS: support S3 strong consistency (#1863)" #1945
Merged
+15
−94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c882ac9.
@jackye1995 I wanted to propose reverting #1863 and going back to the HEAD operation for
exists()andcontentLength()FileIO operations. There was some discussion on the dev list and apparently there's some level of confirmation that negative caching with HEAD operations is covered (and possibly strong consistency?) in the recent announcement around S3 consistency.Iceberg isn't using this operation for consistency and the major concern I have is that the LIST operation cost appears to be 10X (or more) than the HEAD operation, which could really add up depending on usage.
I just wanted to put this up for discussion and see if there's any real advantage at this point to using LIST.
(cc @giovannifumarola, @kbendick, @massdosage and @rdblue since you were all on the original thread)