[Misc] Remove non-test uses of commons-lang3#2102
Merged
rdblue merged 1 commit intoapache:masterfrom Jan 22, 2021
Merged
Conversation
kbendick
reviewed
Jan 17, 2021
rdsr
reviewed
Jan 18, 2021
kbendick
reviewed
Jan 18, 2021
Member
Author
|
@rdblue Could you please review this PR ? |
Contributor
|
LG!. I realize that you might have to update the LICENSE file which lists all the code we have borrowed from different project. |
Member
Author
Updated |
rdsr
approved these changes
Jan 19, 2021
rdblue
reviewed
Jan 19, 2021
rdblue
reviewed
Jan 19, 2021
rdblue
reviewed
Jan 19, 2021
Member
Author
|
CI failed because of #2098 |
pan3793
force-pushed
the
2100
branch
2 times, most recently
from
4272888 to
c551b1b
Compare
rdblue
reviewed
Jan 22, 2021
| public static byte[] serializeToBytes(Object obj) { | ||
| try (ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
| ObjectOutputStream oos = new ObjectOutputStream(baos)) { | ||
| ObjectOutputStream oos = new ObjectOutputStream(baos)) { |
Contributor
There was a problem hiding this comment.
Can you remove the whitespace only changes in this file?
Contributor
|
The only remaining issues were nits, so I merged this. Thanks @pan3793! |
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/iceberg
that referenced
this pull request
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2100