ExpireSnapshots: do not commit when no snapshots are expired. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@danielcweeks, can you review this? |
rdsr
reviewed
Dec 6, 2018
| TableMetadata updated = internalApply(); | ||
| ops.commit(base, updated); | ||
| // only commit the updated metadata if at least one snapshot was removed | ||
| if (updated.snapshots().size() != base.snapshots().size()) { |
Contributor
There was a problem hiding this comment.
Would it be more precise to check for if (updated.snapshots().size() < base.snapshots().size())?
Contributor
There was a problem hiding this comment.
I think those two checks are functionally equivalent for this check. This is to effectively check that the number of snapshots has not changed. I would err on the side of equality as the proposed change would conceptually mean that you could increase the number of snapshots, which would not be expected in this case.
Contributor
|
+1 |
Contributor
Author
|
Thanks for the reviews! |
puchengy
added a commit
to puchengy/iceberg
that referenced
this pull request
Dec 20, 2022
The CI is failing because a new version of mypy has been released yesterday: https://pypi.org/project/mypy/0.982/ (cherry picked from commit 2868871) Co-authored-by: Fokko Driesprong <fokko@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.