Orc: Correct Metrics Modes for nested fields #2977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
commented
Aug 14, 2021
aokolnychyi
approved these changes
Aug 17, 2021
Contributor
aokolnychyi
left a comment
aokolnychyi
left a comment
There was a problem hiding this comment.
LGTM. I had one minor comment on reusing MetricsUtil. Thanks, @szehon-ho!
Contributor
|
Triggered CI once again as not all tests completed. Will merge once green. |
Contributor
|
Thanks, @szehon-ho! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a new PR, but one I was trying to fix along with #2240, found at the time when writing unit tests for configured metrics modes for nested structs.
To be clearer, breaking this fix out to separate PR and adding a specific unit test to reproduce problem.