Core: Add FileWriter interface #3149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @openinx @stevenzwu @RussellSpitzer @rdblue @kbendick @karuppayya @flyrain @pvary @jackye1995 @yyanyy @szehon-ho @rymurr @jun-he This PR contains a subset of changes in PR #2945. |
aokolnychyi
commented
Sep 18, 2021
| * A factory for creating data and delete writers. | ||
| */ | ||
| public interface WriterFactory<T> { | ||
| public interface FileWriterFactory<T> { |
Contributor
Author
There was a problem hiding this comment.
This API was added recently and we haven't consumed it anywhere yet.
aokolnychyi
force-pushed
the
file-writer
branch
from
9a90f18 to
4d41a62
Compare
aokolnychyi
commented
Sep 19, 2021
| this.keyMetadata = keyMetadata != null ? keyMetadata.buffer() : null; | ||
| this.delete = PositionDelete.create(); | ||
| this.pathSet = CharSequenceSet.empty(); | ||
| this.referencedDataFiles = CharSequenceSet.empty(); |
Contributor
Author
aokolnychyi
force-pushed
the
file-writer
branch
from
4d41a62 to
ea0af86
Compare
rdblue
reviewed
Sep 19, 2021
rdblue
reviewed
Sep 19, 2021
core/src/main/java/org/apache/iceberg/io/EqualityDeleteWriteResult.java
Outdated
Show resolved
Hide resolved
rdblue
approved these changes
Sep 19, 2021
Contributor
|
Looks good overall. My only complaint is that I doubt we need separate result classes for both position and equality deletes. But that's minor and up to you. Merge when you're ready and tests are passing! |
aokolnychyi
force-pushed
the
file-writer
branch
from
ea0af86 to
5e3d593
Compare
Contributor
Author
|
Thanks for reviewing, @rdblue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
FileWriterinterface that defines a contract for writing a number of files of a single type within one spec/partition.