Skip to content

Conversation

@kbendick
Copy link
Contributor

This PR is trying to address this comment: #3501 (comment)

It seems that checkstyle has not been running for some (or all) of the Java / Scala code outside of java-ci.yml due to -Pquick=true.

I had noticed and fixed a rogue checkstyle issue that made it in, but I thought it slipped in during the refactoring of tests as a one time thing.

@openinx suggested in this PR: #3509 that we remove the path ignores in java-ci.yaml. But I think that would negate the work of splitting up the tests and the speed built up that we have seen from that.

I'm happy to revert this PR if we go with that decision, but I wanted to ensure all checks are passing in CI currently.

@github-actions github-actions bot added the INFRA label Nov 10, 2021
@rdblue
Copy link
Contributor

rdblue commented Nov 14, 2021

I don't think this is the right approach. We purposely disable checkstyle and others because those should be run in other workflows. That is the purpose of the "build-checks" job in java-ci.yml. Looks like that doesn't ensure all Spark and Flink versions are enabled, which is one reason why some of the checks were missing. In addition, it looks like the Java CI ignores spark and flink folders. I think the core tests should always run, even if only Spark is modified.

@rdblue
Copy link
Contributor

rdblue commented Nov 14, 2021

Closing since this was just fixed by #3509.

@rdblue rdblue closed this Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants