Spark: Add option to introduce ordering of RewriteFileGroup #4377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
from
7469626 to
f8b9bbd
Compare
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/actions/RewriteFileGroup.java
Outdated
Show resolved
Hide resolved
....2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
Outdated
Show resolved
Hide resolved
....2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
Outdated
Show resolved
Hide resolved
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
6 times, most recently
from
4de2828 to
34b70ca
Compare
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
Outdated
Show resolved
Hide resolved
....2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
Outdated
Show resolved
Hide resolved
....2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
Outdated
Show resolved
Hide resolved
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Show resolved
Hide resolved
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
2 times, most recently
from
de8118f to
d21536c
Compare
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
3 times, most recently
from
6f9858e to
067c849
Compare
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/actions/RewriteFileGroup.java
Outdated
Show resolved
Hide resolved
....2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
Outdated
Show resolved
Hide resolved
....2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
Outdated
Show resolved
Hide resolved
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Outdated
Show resolved
Hide resolved
RussellSpitzer
requested changes
Apr 6, 2022
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Left some notes on Enum usage, we can remove some of the if statements by
using built in functions and switch statements.
Tests can probably be simplified a bit to just check the task ordering.
Other than that I think we are general good to go
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
2 times, most recently
from
6ed30e1 to
9508eef
Compare
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
from
9508eef to
769c088
Compare
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Show resolved
Hide resolved
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
2 times, most recently
from
2c3e1cf to
2d7197f
Compare
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
from
2d7197f to
84658a6
Compare
Contributor
Author
|
@RussellSpitzer PR is ready for another round of review. |
....2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSparkAction.java
Show resolved
Hide resolved
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Outdated
Show resolved
Hide resolved
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Outdated
Show resolved
Hide resolved
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
3 times, most recently
from
24ba231 to
5f4803e
Compare
rajarshisarkar
force-pushed
the
rewrite-data-files-order
branch
from
5f4803e to
efc59b7
Compare
RussellSpitzer
approved these changes
Apr 15, 2022
Member
|
Thanks for the patch @rajarshisarkar , Let's do a quick followup to move the changes into 3.0 and 3.1 |
aokolnychyi
reviewed
Apr 15, 2022
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 9, 2023
) Allows users to specify the order in which Rewrite JobGroups should be executed. (cherry picked from commit d1476c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ordering of
RewriteFileGroup. This should be helpful in cases where we want to force the compaction order according to the size (in bytes) or number of files.Introduce a new Spark option
rewrite.job-order = {"bytes-asc", "bytes-desc", "files-asc", "files-desc", "none"}.rewrite.job-order=bytes-asc: rewrite the smallest job groups first.rewrite.job-order=bytes-desc: rewrite the largest job groups first.rewrite.job-order=files-asc: rewrite the job groups with the least files first.rewrite.job-order=files-desc: rewrite the job groups with the most files first.rewrite.job-order=none: rewrite job groups in the order they were planned (no specific ordering).cc: @RussellSpitzer