Parquet: Avoid modifying existing conf of HadoopOutputFile rather create new one #4411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the fix. |
singhpk234
changed the title
jackye1995
reviewed
Mar 28, 2022
jackye1995
reviewed
Mar 28, 2022
...sions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java
Outdated
Show resolved
Hide resolved
rajarshisarkar
approved these changes
Mar 31, 2022
Contributor
Author
|
@openinx can you please take a pass when you have some time |
openinx
approved these changes
Apr 2, 2022
Member
|
Got this merged, thanks @singhpk234 for the contribution ! |
kbendick
pushed a commit
to kbendick/iceberg
that referenced
this pull request
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we faced concurrent modification issue in ORC when trying to modify existing hadoop conf from HadoopFileIO in ORC write builder. ref : Issue#4383, PR#4384
Looks like this code snippet was present in Parquet#write as well, based on discussion #3810 (comment)
As per my understanding, we should do the same changes as we did in the ORC, here in parquet. The issue we had in ORC (given that we expect our PR fixed it), could also happen in Parquet#write under same circumstances, added a test for the same
cc @openinx, @hililiwei , @rdblue