Skip to content

Conversation

@rdblue
Copy link
Contributor

@rdblue rdblue commented Sep 4, 2019

This moves the Hive concurrency tests into a separate suite and adds synchronized to the test methods so that the test cases do not run concurrently. This should make those tests more reliable because they assume no other tests are using the Hive connection pool.

@rdblue
Copy link
Contributor Author

rdblue commented Sep 4, 2019

@xabriel, I think this should fix your current CI test failures. Can you take a look?

@rdblue rdblue requested a review from aokolnychyi September 4, 2019 16:28
Copy link
Contributor

@xabriel xabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@rdsr rdsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rdblue
Copy link
Contributor Author

rdblue commented Sep 4, 2019

Thanks, I'll merge this to unblock #432.

@rdblue rdblue merged commit 32ac506 into apache:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants