Core : Strip trailing slash from tableLocation in LocationProvider #4585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
force-pushed
the
fix/removeTrailingSlash
branch
from
c465157 to
53540e4
Compare
rdblue
reviewed
Apr 19, 2022
rdblue
reviewed
Apr 19, 2022
rdblue
reviewed
Apr 19, 2022
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Apr 19, 2022
Contributor
|
Thanks, @singhpk234! Looks mostly good, but I think we should use just one |
singhpk234
force-pushed
the
fix/removeTrailingSlash
branch
from
c90e221 to
a00888d
Compare
rdblue
reviewed
Apr 19, 2022
rdblue
approved these changes
Apr 20, 2022
Contributor
|
Thanks, @singhpk234! |
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 9, 2023
Co-authored-by: Prashant Singh <psinghvk@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4582
This change attempts to fix :
locationsForwe don't sanitize the location (i.e strip the trailing slash), this attempts to do this strippingNote : nessie Catalog also doesn't have this handling, will do the same in next iteration of this pr if experts from nessie suggests this is required (appologies I am new to nessie)
cc @szehon-ho , @RussellSpitzer , @jackye1995 , @flyrain