Nessie: Use memoized Supplier to avoid unnecessary API calls #4593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
memoized-supplier
branch
from
c36ffe9 to
739a6d8
Compare
| } | ||
|
|
||
| @Test | ||
| public void testCommitsOutsideOfCatalogApi() throws NessieNotFoundException, NessieConflictException { |
Member
There was a problem hiding this comment.
Is this set of changes required? I think we just changed this in the last PR
Contributor
Author
There was a problem hiding this comment.
yes those are required as the "reference loading" behavior is how it was previously and therefore that test that I rewrote is now valid again. This was unfortunately an oversight on my side as we should have been using a memoized supplier from the very beginning
RussellSpitzer
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this also reverts the test changes that were done in 9618147#diff-a92127e5d74e2be0c013d0eddf4c9d2af29a71f05e21d7289808271d4c97db78L326-R348