Nessie: Prevent accidental deletion of files which are still referenced by other branches/tags #5718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by other branches/tags
nastra
approved these changes
Sep 7, 2022
dimas-b
approved these changes
Sep 7, 2022
Member
Author
|
Can one of the committers please help merge this PR? cc: @rdblue, @pvary, @Fokko, @RussellSpitzer, @snazy |
Fokko
reviewed
Sep 8, 2022
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java
Show resolved
Hide resolved
Fokko
approved these changes
Sep 8, 2022
Contributor
|
Thanks @ajantha-bhat 🙌🏻 |
Contributor
|
just fyi that I removed this from the Iceberg 1.0.0 Release because 1.0.0 is supposed to be 0.14.1 + spotless + Deprecation cleanups only |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg GC functionalities like
remove_orphan_files,expire_snapshots,drop_table(withpurge=true) are not aware of the Nessie's branches and tags.So, when a user accidentally calls these on Nessie-managed tables, these GC functionalities will clean up the files which are still referenced in other branches/tags. So, blocking all the Iceberg GC operations on Nessie-managed tables by default.
Nessie will provide engine agnostic, reference-aware GC functionalities (which doesn't call these Iceberg GC functionalities internally) with CLI support for handling the GC of expired/unreferenced files of a Nessie managed table.