Build: relocate httpclient5 dependency for runtime jars #5761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@pan3793 : Please take a look |
Member
|
The change LGTM, which part relies on httpclient5? better to verify the runtime jar works manually, because relocation is not always safe. |
ajantha-bhat
force-pushed
the
relocate
branch
from
79c7778 to
9bbb79b
Compare
Member
Author
@pan3793: As mentioned, REST catalog uses this |
nastra
approved these changes
Sep 14, 2022
Fokko
approved these changes
Sep 14, 2022
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Looks like we have all of them 👍🏻
grep -R "relocate 'org.threeten.extra'" . | wc -l
9
JonasJ-ap
pushed a commit
to JonasJ-ap/iceberg
that referenced
this pull request
Sep 18, 2022
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST API catalog introduces a dependency on httpclient5 and it is included without proper relocation.
So, relocate httpclient5 dependency for runtime jars to avoid conflicts.