Infer mapping from expected schema if file schema does not have field-ids and name mapping is missing #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdsr
changed the title
rdblue
reviewed
Oct 27, 2019
rdblue
reviewed
Oct 27, 2019
core/src/main/java/org/apache/iceberg/avro/ProjectionDatumReader.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Oct 27, 2019
Contributor
|
Thanks @rdsr! Looks good. I think that the logic should be that if any ID is assigned, we don't use fallback assignment. We have to assume that if a file has any explicit ID then it was written with IDs. I think I got the logic wrong in the Parquet fallback. We should fix that as well (though not in this PR). |
…nd name mapping is missing Fixes apache#528
Contributor
Author
|
@rdblue, thanks for taking a look. I've addressed your comments. |
Contributor
|
Thanks @rdsr! I merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #528
@rdblue . I've written
AvroSchemaUtil.hasIdssimilar to Parquet's, in that if at least 1 field-id is missing we consider the schema to have no ids. This is slightly different from your comment on #528.