Build: Show executed tests on CI only #6007
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been added a while ago by apache#1212 but then got lost over time. Sometimes it's quite helpful to know whether a particular test has been executed on CI. This PR makes sure that the executed tests are only shown on CI and not during local test execution.
Contributor
|
The only drawback I can think of is if this makes tests take longer. I'd probably not do this since it sounds like you can work around this for cases where you need to. If you want to make sure an integration test ran, then do that once rather than doing this all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been added a while ago by #1212 but then got removed by #2013. Sometimes it's quite helpful to know whether a particular test has been executed on CI by looking at the Gradle output
This PR makes sure that the executed tests are only shown on CI and not during local test execution.
@rdblue do you see any major drawback to doing this (other than having bigger log files)? I've been multiple times in the past in a situation where I wanted to double-check that a particular test has been really part of CI.
The most recent case was after I added some integration tests with #6001. It would have been quite useful to know that those integration tests have been executed as part of CI - currently you can only see that the
integrationTesttask has been running, but you don't have a way of knowing that the test(s) have been executed.