Python: Add boolean expression parser #6259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
commented
Nov 26, 2022
| assert And(NotNull("x"), Or(LessThan("x", 5), GreaterThan("x", 10))) == parser.parse("x is not null and (x < 5 or 10 < x)") | ||
| assert Or(IsNull("x"), And(GreaterThanOrEqual("x", 5), Not(LessThan("x", 10)))) == parser.parse( | ||
| "(x is null) or (5 <= x) and not(x < 10)" | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
I verified that the result of these complex cases matches Spark.
Fokko
approved these changes
Nov 28, 2022
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Some cosmetic changes, but apart from that it looks great. I think this is a great addition to the library
| return hash(self.value) | ||
|
|
||
| def __eq__(self, other: Any) -> bool: | ||
| if not isinstance(other, Literal): |
Contributor
There was a problem hiding this comment.
If we get something else, we could wrap it in a literal and compare it. This would allow literal(1) == 1.
Contributor
Author
There was a problem hiding this comment.
I don't think that we want to do that. Then equality would not be symmetric.
| return GreaterThanOrEqual(result.column, result.literal) | ||
| if result.op in ("=", "=="): | ||
| return EqualTo(result.column, result.literal) | ||
| if result.op in ("!=", "<>"): |
Contributor
There was a problem hiding this comment.
Suggested change
| if result.op in ("!=", "<>"): | |
| elif result.op in ("!=", "<>"): |
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Contributor
Author
|
Merged. Thanks for reviewing, @Fokko! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple expression parser based on pyparsing.