Python: Fix timezone concat issue #6946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-fix-timezone-issue
branch
2 times, most recently
from
5af2047 to
b3191cc
Compare
Fokko
force-pushed
the
fd-fix-timezone-issue
branch
from
b3191cc to
8401493
Compare
rdblue
reviewed
Feb 28, 2023
|
|
||
| def visit_timestampz(self, _: TimestamptzType) -> pa.DataType: | ||
| return pa.timestamp(unit="us", tz="+00:00") | ||
| return pa.timestamp(unit="us", tz="UTC") |
Contributor
There was a problem hiding this comment.
Why change all uses to UTC rather than +00:00? Aren't these the same thing?
Contributor
Author
There was a problem hiding this comment.
Technically yes. #6945 has a deeper explanation for this. It is because the test data is written using a docker container that is using UTC.
rdblue
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6945
I'm aware that I didn't add any tests to cover this. I think it would be nice to get the integration tests in: #6398 Or have write support in Python.
Tested this by running a scan that will filter out data (December 2021):
This fails on the current master:
